Fetch#22

Merged

jakubdrozdek merged 16 commits into

javascript-tutorial:masterfrom

mitroc:master

Oct 20, 2019

mitroc commented Oct 5, 2019

Contributor

No description provided.

mitroc added 7 commits

October 5, 2019 20:29


          Translated 'sever.js'

e8b6c59


          Translate 'task.md'

9470b2a


          Translate 'solution'

27af43f


          Translate 'test.js'

d9a9d01


          Translated 'source.js'

835aaba


          Translated 'article.md'

363bc8e


          Correct 'article.md'

625b23f

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

October 5, 2019 21:29

CLAassistant commented Oct 5, 2019 •

edited

Loading

All committers have signed the CLA.

iliakan mentioned this pull request

Polish Translation Progress #1

Open

mitroc added 3 commits

October 6, 2019 01:23


          Translate 'article.md'

61c7794


          Reword 'article.md'


          Translate 'server.js'

c178a41

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/01-fetch-users/_js.view/test.js Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/01-fetch-users/solution.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/01-fetch-users/task.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/01-fetch-users/task.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/01-fetch-users/task.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/01-fetch/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek reviewed

View reviewed changes

5-network/02-formdata/article.md Outdated

jakubdrozdek commented Oct 6, 2019 •

edited

Loading

Contributor

@mitroc Dobra robota! :) Podoba mi się to tłumaczenie. Oczywiście, musiałem wtrącić swoje trzy grosze (wyszły aż 52 grosze ;-) ), ale ogólne tłumaczenie jest na dobrym poziomie.
Jeszcze tylko ogarnij Git flow i praca będzie szła sprawnie.

Jako że to Twój pierwszy PR, możesz tego nie wiedzieć:
GitHub umożliwia łatwe zaaplikowanie sugerowanych zmian z poziomu dyskusji. Wystarczy dodać wszystkie sugestie do "batcha" i na koniec zaakceptować, tworząc pojedynczego commita ze wszystkimi zmianami.

jakubdrozdek added changes requested and removed review needed labels


          Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…

52f7556

…vascript.info

mitroc commented Oct 7, 2019 •

edited

Loading

Contributor Author

@jakubdrozdek W mordę, strasznie ten interfejs mają zawinięty. W robocie używamy bitbucketa, więc tu się gubię. Czyli widzę, że mogę zrobić pojedynczy commit, albo dodać do grupowego. Spoko. To co w takim razie robi pod spodem przycisk Resolve conversation, oprócz tego, że:

The entire conversation will be collapsed and marked as resolved, making it easier to find conversations that still need to be addressed.

Bo po tym, jak już jest resolved nie można dodać do batcha 😄 i trzeba zrobić unresolve, więc trochę podwójna robota. 😞

jakubdrozdek commented Oct 7, 2019 •

edited

Loading

Contributor

Resolve conversation robi się automatycznie, gdy tylko wrzucisz commita z poprawkami dotyczącymi danej linii, o którą się rozchodzi we wspomnianym 'conversation'. Jeśli jednak komentarz nie wnosi niczego szczególnego albo nie zgadzasz się z nim i razem ustalimy, że jednak nie ma sensu czegoś zmieniać tak, jak to zasugerowałem, to możesz resolvować dla samego porządku w PR-ze :)

jakubdrozdek commented Oct 7, 2019

Contributor

Z tego co widzę, to nie poprawiłeś kompletnie nic, a oznaczyłeś wątki jako 'resolved'... Przejdź jeszcze raz przez wszystko, daj 'unresolved', a później zrób batcha :-)

mitroc commented Oct 8, 2019

Contributor Author

Ech....

mitroc and others added 3 commits

October 8, 2019 11:35


          Apply suggestions from code review

3b71594

Co-Authored-By: Jakub Drozdek <30927218+jakubdrozdek@users.noreply.github.com>


          Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…

3adf2cd

…vascript.info


          Merge branch 'master' of https://github.com/mitroc/pl.javascript.info

5d606ab

mitroc commented Oct 19, 2019

Contributor Author

@jakubdrozdek Rzucisz okiem na te otwarte kwestie?

jakubdrozdek commented Oct 19, 2019

Contributor

@mitroc Wybacz, zupełnie mi umknął ten PR... Odpowiedziałem i mój wniosek jest taki, że lepiej nie pisać nic niż napisać głupotę :-) Piszmy bez "klasa".

mitroc added 2 commits

October 20, 2019 13:46


          Merge branch 'master' of https://github.com/javascript-tutorial/pl.ja…

ae0d66f

…vascript.info


          Apply code review suggestions

c20bed7

jakubdrozdek approved these changes

View reviewed changes

javascript-translate-bot added needs +1 and removed changes requested labels

jakubdrozdek merged commit 54bac9e into javascript-tutorial:master

javascript-translate-bot commented Oct 20, 2019

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels