Skip to content

Nullish coalescing operator '??'#73

Merged
CheerfulCherry merged 7 commits into
javascript-tutorial:masterfrom
sculpt0r:1-02-12_Nullish
Oct 15, 2022
Merged

Nullish coalescing operator '??'#73
CheerfulCherry merged 7 commits into
javascript-tutorial:masterfrom
sculpt0r:1-02-12_Nullish

Conversation

@sculpt0r

@sculpt0r sculpt0r commented Oct 24, 2020

Copy link
Copy Markdown
Contributor

Translated to Polish

@javascript-translate-bot javascript-translate-bot requested a review from a team October 24, 2020 20:03
@CLAassistant

CLAassistant commented Oct 24, 2020 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@javascript-translate-bot javascript-translate-bot mentioned this pull request Oct 24, 2020
Open
akowalska622
akowalska622 suggested changes Nov 7, 2021
View reviewed changes

@akowalska622 akowalska622 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good translation, one of the best here, kudos!
I suggested some minor changes, but without them the translation is also good to publish.

One comment about my first suggestion: polish version of MDN suggests different name for the nullish coalescing operator, I've mentioned it once, but if the author of PR decides to change it according to MDN, please check all of the occurrences in the whole text.

Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
@javascript-translate-bot

javascript-translate-bot commented Nov 7, 2021

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@akowalska622

akowalska622 commented Nov 7, 2021

Copy link
Copy Markdown

Oh, and please sign CLA :)

@sculpt0r

sculpt0r commented Aug 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @akowalska622 ,
almost a year two years 😰 but I made corrects - sorry for such a long time with no response. Also, CLA is signed :)

@sculpt0r

sculpt0r commented Aug 12, 2022

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team August 12, 2022 11:41
@sculpt0r sculpt0r requested a review from akowalska622 August 12, 2022 11:41
CheerfulCherry
CheerfulCherry reviewed Sep 17, 2022
View reviewed changes
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
CheerfulCherry
CheerfulCherry reviewed Sep 17, 2022
View reviewed changes
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
CheerfulCherry
CheerfulCherry reviewed Sep 17, 2022
View reviewed changes
Comment thread 1-js/02-first-steps/12-nullish-coalescing-operator/article.md Outdated
CheerfulCherry
CheerfulCherry suggested changes Sep 17, 2022
View reviewed changes

@CheerfulCherry CheerfulCherry left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM poza małymi "kosmetycznymi" poprawkami 🙂

@javascript-translate-bot

javascript-translate-bot commented Sep 17, 2022

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@sculpt0r

sculpt0r commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested review from a team and removed request for akowalska622 October 13, 2022 17:00
@CheerfulCherry CheerfulCherry merged commit 051f376 into javascript-tutorial:master Oct 15, 2022
@javascript-translate-bot

javascript-translate-bot commented Oct 15, 2022

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poplaw poplaw poplaw approved these changes

+2 more reviewers

@akowalska622 akowalska622 akowalska622 requested changes

@CheerfulCherry CheerfulCherry CheerfulCherry approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs +1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sculpt0r @CLAassistant @javascript-translate-bot @akowalska622 @poplaw @CheerfulCherry