Skip to content

Patterns and flags#135

Merged
lenchen1112 merged 3 commits into
javascript-tutorial:masterfrom
fixiabis:master
Apr 20, 2021
Merged

Patterns and flags#135
lenchen1112 merged 3 commits into
javascript-tutorial:masterfrom
fixiabis:master

Conversation

@fixiabis

Copy link
Copy Markdown
Contributor

Target chapter

9-regular-expressions/01-regexp-introduction

Modified files

File name Change(reason)
article.md 翻譯繁體中文

@CLAassistant

CLAassistant commented Apr 12, 2021

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@lenchen1112 lenchen1112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts :)

Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated
Comment thread 9-regular-expressions/01-regexp-introduction/article.md Outdated

@lenchen1112 lenchen1112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions.

@javascript-translate-bot

Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@fixiabis

Copy link
Copy Markdown
Contributor Author

/done

@lenchen1112 lenchen1112 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @javascript-tutorial/translate-zh-hant anyone has concerns?

@ArvinH ArvinH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fixiabis

Copy link
Copy Markdown
Contributor Author

Just signed.

@lenchen1112 lenchen1112 merged commit 075e078 into javascript-tutorial:master Apr 20, 2021
@javascript-translate-bot

Copy link
Copy Markdown

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants