Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

#2017 Keptn CloudEvent spec for new Shipyard#50

Merged
johannes-b merged 5 commits into
masterfrom
feature/2107/cloudevents_for_v2
Dec 22, 2020
Merged

#2017 Keptn CloudEvent spec for new Shipyard#50
johannes-b merged 5 commits into
masterfrom
feature/2107/cloudevents_for_v2

Conversation

@johannes-b

@johannes-b johannes-b commented Dec 16, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Johannes johannes.braeuer@dynatrace.com

@johannes-b
#2017 Working on CloudEvent spec
0d00c7f 
Signed-off-by: Johannes <johannes.braeuer@dynatrace.com>
@warber

warber commented Dec 17, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

There are a bunch of events missing. E.g. service.create, service.delete, project.create, project.delete, problem.open, monitoring configured , ...
Also, there are some errors contained in the examples and json schemas (e.g., the example for remediation.triggered is not correct anymore)

There are probably other errors as well which is not surprising, as this page is manually created which is an error-prone process.... we need to think of a way to auto-generate the examples and json schemas.

I've created an issue for that: see #51

warber added 4 commits December 21, 2020 13:23
#2107 added content of generated cloudevents spec
38ba20c 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
#2107 collapsable codeblocks
2291458 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
#2107 expanded examples code block
08c302b 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
#2107 cleanup
61909c0 
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
@johannes-b

johannes-b commented Dec 22, 2020

Copy link
Copy Markdown
Member Author

@warber really great work with your automation that extracts the CloudEvent definition from the GO structs! From my point of view, the PR looks good and can be approved.

Since I filed the PR, I can't approve it. @christian-kreuzberger-dtx or @agrimmer can you please take a look?

christian-kreuzberger-dtx
christian-kreuzberger-dtx approved these changes Dec 22, 2020
View reviewed changes

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johannes-b johannes-b merged commit ccfee69 into master Dec 22, 2020
@johannes-b johannes-b deleted the feature/2107/cloudevents_for_v2 branch December 22, 2020 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AloisReitbauer AloisReitbauer Awaiting requested review from AloisReitbauer AloisReitbauer is a code owner

@danielkhan danielkhan Awaiting requested review from danielkhan

1 more reviewer

@christian-kreuzberger-dtx christian-kreuzberger-dtx christian-kreuzberger-dtx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@johannes-b @warber @christian-kreuzberger-dtx