Skip to content
This repository was archived by the owner on Dec 21, 2023. It is now read-only.

Fixed JSON schema to make properties of a task optional#77

Merged
johannes-b merged 1 commit into
masterfrom
patch/shipyard-json-schema
May 12, 2021
Merged

Fixed JSON schema to make properties of a task optional#77
johannes-b merged 1 commit into
masterfrom
patch/shipyard-json-schema

Conversation

@johannes-b

Copy link
Copy Markdown
Member

This PR:

  • Changes the JSON schema of Shipyard to make the properties of a task optional and not mandatory
  • Sets the type of properties to object.

The examples of a Shipyard show this correctly, but the JSON schema was wrong:

    - name: hardening
      sequences:
        - name: delivery
          triggeredOn:
          - event: dev.delivery.finished
          tasks:
          - name: deployment
            properties:
              deploymentstrategy: blue_green_service
          - name: test
            properties:
              teststrategy: performance
          - name: evaluation                                         < e.g., does not have `properties` 
          - name: release

Signed-off-by: Johannes johannes.braeuer@dynatrace.com

Signed-off-by: Johannes <johannes.braeuer@dynatrace.com>
@johannes-b johannes-b changed the title Make properties of a task optional Fixed JSON schema to make properties of a task optional May 12, 2021

@christian-kreuzberger-dtx christian-kreuzberger-dtx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johannes-b johannes-b merged commit 2c1e657 into master May 12, 2021
@johannes-b johannes-b deleted the patch/shipyard-json-schema branch May 12, 2021 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants