Rename cmake project from 'check' to 'Check'#232
Merged
Conversation
mikkoi
commented
Oct 25, 2019
Contributor
Check should be written with a capital letter. In a CMake script this makes a difference as `find_package(Check)` should work, not `find_package(check)`. This change does not alter how Check is installed. Maintaining compatibility with GNU Autotools installation is mandatory. Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Signed-off-by: Mikko Johannes Koivunalho <mikko.koivunalho@iki.fi>
Contributor
|
If I understand the change, it will not affect CMake users' projects if they upgrade Check to this change, is that right? For example, could updating Check result in it no longer being found for a CMake project in Windows due to the name change? |
Contributor
Author
|
This change will not alter the behaviour how CMake projects are currently discovering Check. Since we have not supported CMake's own discovery methods before, including Cmake Package Registry, current users are using the Find*.cmake file method, as described in our documentation (:doc/example/cmake/FindCheck.cmake). This Find file uses the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.