fix(processor,ui): show meaningful noise floor for voice-activated input#138
Merged
Conversation
Add InputDisplayNoiseFloorDB resolver that returns the astats room-tone floor normally, or the VAD momentary-LUFS floor for voice-activated captures (where astats silence is a meaningless -120 dB sentinel). Route both the live Analysis box and done-box "before" through this resolver so they display the same input floor for all files. The quality score continues to read InputRoomToneFloorDB directly, preserving its axis. Result: done-box now reads meaningful before/after values for voice-activated files, consistent with the normal recording layout and aligned with the live box floor display. Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Confidence score: 4/5
- In
internal/ui/summary.go, the VAD separation calculation does not treatMeasuredNoiseFloor==0as the “unmeasured” sentinel, so it can replace the astats fallback with a bogus momentary gap and surface incorrect separation values to users — add the sentinel guard so the astats-derived value is preserved when noise floor is unmeasured before merging.
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
…activated mode Add guard `MeasuredNoiseFloor != 0` before computing momentary separation to mirror the floor resolver's guard, ensuring the floor and separation agree on usability. Add test `TestSeparationDBVoiceActivatedUnmeasuredFloor`. Signed-off-by: Martin Wimpress <code@wimpress.io>
Contributor
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Requires human review: Introduces a new resolver that toggles between RMS and VAD for voice captures, altering the noise floor path and display logic across processor and UI; this axis behavior change warrants human review.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add InputDisplayNoiseFloorDB resolver that returns the astats room-tone
floor normally, or the VAD momentary-LUFS floor for voice-activated
captures (where astats silence is a meaningless -120 dB sentinel).
Route both the live Analysis box and done-box "before" through this
resolver so they display the same input floor for all files. The quality
score continues to read InputRoomToneFloorDB directly, preserving its
axis.
Result: done-box now reads meaningful before/after values for
voice-activated files, consistent with the normal recording layout and
aligned with the live box floor display.