Refactor: Unify lifespan hooks#1663
Merged
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Implements #1634, as discussed in #1635.
The following application hooks were removed:
before_startupafter_startupbefore_shutdownafter_shutdownThe hooks
on_startupandon_shutdownhave been altered to optionally accept an application instance as their only argument. The decision to keep this detail around was made to more easily allow to re-use existing callables and pass them to the hooks, without having to wrap them in another callable which accepts a positional argument.In addition, the
lifespanargument toLitestaret. al was changed to allow instances ofAbstractAsyncContextManageralongside callables which return such context managers. This was done to allow e.g. plugins to inject themselves as a lifespan manager.