Improvements in scalebar and scaleDenom mapgraphics#219
Conversation
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
fgdrf
left a comment
There was a problem hiding this comment.
@nprigour Thanks for this pull request!
I'm not sure about encoding and save/restore behavior after restart. Which encoding is used to store the label text in the Memento? Is it worth to test with different encodings here?
@egouge What do you think from another user perspective? IMHO its worth to merge it into codebase and uses can Just name the scale in their language.
|
As long as this is optional & special characters from other languages work I think this is fine. |
There was a problem hiding this comment.
It would be great if you could add a screenshot for a page listed in https://udig.github.io/docs/user/reference/Style%20Pages.html and describe the option shown in the screenshot
If you need help, let me know. Normally the the RST Markdown is straight forward to write, there is a little sphinx guide you can find here and the rst files you can finde down below docs
|
@egouge Thanks for your feedback! Have you tested changes on your machine? I haven't tested yet, going to test it this afternoon |
Signed-off-by: Nikolaos Pringouris <nprigour@gmail.com>
|
from some testing I performed I do not think there is any problem with the memento saving and restore. sphinx documentation updated |
Improvements include:
Signed-off-by: Nikolaos Pringouris nprigour@gmail.com