Skip to content

splits style.advanced into raster and feature bundle#270

Merged
fgdrf merged 2 commits into
locationtech:masterfrom
fgdrf:F_split_up_advanced_style
Mar 29, 2018
Merged

splits style.advanced into raster and feature bundle#270
fgdrf merged 2 commits into
locationtech:masterfrom
fgdrf:F_split_up_advanced_style

Conversation

@fgdrf

@fgdrf fgdrf commented Mar 24, 2018

Copy link
Copy Markdown
Contributor

Main idea is to create seperate bundles for advanced styling to use these side by side and standalone from each other. Asume you have a product that has only support for featuretypes, the customer should not get Raster-Styling pages displayed (the product then would not include style.advanced.raster whereas style.advanced.feature is included (was style.advanced)

  • cleans codebase regading ColorEditors, removes StolenColorEditor
  • moves common usable classes to public packages
  • moves common functionality to style.advanced.core module
  • renames style.advanced to style.advanced.feature

Signed-off-by: Frank Gasdorf fgdrf@users.sourceforge.net

@fgdrf fgdrf requested a review from jodygarnett March 24, 2018 22:22
@fgdrf

fgdrf commented Mar 24, 2018

Copy link
Copy Markdown
Contributor Author

@moovida Are you kind enought to review and comment changes I made? Especially all changes regarding ColorEditors ;)

@fgdrf

fgdrf commented Mar 24, 2018

Copy link
Copy Markdown
Contributor Author

Relates to #269

fgdrf added 2 commits March 29, 2018 21:56
* cleans codebase regading ColorEditors, removes StolenColorEditor
* moves common usable classes to public packages
* moves common functionality to style.advanced.core module
* renames style.advanced to style.advanced.feature

Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
@fgdrf fgdrf force-pushed the F_split_up_advanced_style branch from c302f95 to 94e2b8a Compare March 29, 2018 21:09
@fgdrf fgdrf merged commit a49c86c into locationtech:master Mar 29, 2018
@fgdrf fgdrf added this to the uDig-2.0.0 milestone Mar 29, 2018
@fgdrf

fgdrf commented Mar 29, 2018

Copy link
Copy Markdown
Contributor Author

@egouge Again, thank your for testing!

@jodygarnett

Copy link
Copy Markdown
Contributor

Thanks @egouge / @fgdrf - just returning to email now, glad frank was not kept waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants