Conversation
…the contribution item Signed-off-by: HendrikPeilke <hendrik.peilke@ibykus.de>
Contributor
|
I just check and indeed the SelectionListener is called twice. The provided PR fixes these + it adds support for Text Fileds update via the focus listeners. |
Contributor
|
Hi @fgdrf , Maybe we can also include this in 2.1.0? |
Contributor
|
@hendrikpeilke Thanks for this contribution! Kodos to @nprigour for testing and review! |
fgdrf
pushed a commit
to fgdrf/udig-platform
that referenced
this pull request
Dec 23, 2019
…the contribution item (locationtech#306) Signed-off-by: HendrikPeilke <hendrik.peilke@ibykus.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a text field as a tool contribution in multiple tools inside our applications, so I added support in the ToolOptionContributionItem class.
Also fixed the code to have no double listeners: addField and fill used both to add a listener to Buttons, so dropped the listener addition in the fill part and let it all be in the addField method, where it was before. (maybe the fill location was better?) At the same time corrected the listen method, where not all listeners were added / removed.
Signed-off-by: HendrikPeilke hendrik.peilke@ibykus.de