Skip to content

support for text tool contribution and fix of multiple listeners#306

Merged
fgdrf merged 1 commit into
masterfrom
unknown repository
Sep 24, 2019
Merged

support for text tool contribution and fix of multiple listeners#306
fgdrf merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Oct 4, 2018

Copy link
Copy Markdown

We need a text field as a tool contribution in multiple tools inside our applications, so I added support in the ToolOptionContributionItem class.

Also fixed the code to have no double listeners: addField and fill used both to add a listener to Buttons, so dropped the listener addition in the fill part and let it all be in the addField method, where it was before. (maybe the fill location was better?) At the same time corrected the listen method, where not all listeners were added / removed.

Signed-off-by: HendrikPeilke hendrik.peilke@ibykus.de

…the contribution item

Signed-off-by: HendrikPeilke <hendrik.peilke@ibykus.de>
@nprigour

Copy link
Copy Markdown
Contributor

I just check and indeed the SelectionListener is called twice. The provided PR fixes these + it adds support for Text Fileds update via the focus listeners.
Regarding on where exactly to make the listeners addition IMHO and based on the fillFields(...) method description the addField method seems the most appropriate candidate.
I do not see any implication on merging this PR (maybe we just need to remove the commented line 196 to clean up the code).

@nprigour

Copy link
Copy Markdown
Contributor

Hi @fgdrf ,

Maybe we can also include this in 2.1.0?

@fgdrf fgdrf added this to the 2.1.0 milestone Sep 24, 2019
@fgdrf fgdrf merged commit 54a9dbf into locationtech:master Sep 24, 2019
@fgdrf

fgdrf commented Sep 24, 2019

Copy link
Copy Markdown
Contributor

@hendrikpeilke Thanks for this contribution! Kodos to @nprigour for testing and review!

fgdrf pushed a commit to fgdrf/udig-platform that referenced this pull request Dec 23, 2019
…the contribution item (locationtech#306)

Signed-off-by: HendrikPeilke <hendrik.peilke@ibykus.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants