Upgrade GeoTools 22.x

[fgdrf]

In behalf of @egouge I created this pull-request for master

[nprigour]

Hi,

May be it is worth to move to recently released geotools 22.1 (instead of 22.0) which is supposed to be more mature.
During this upgrade we should consider:

• fix [GEOT-6293] ContentFeatureStore.getReader(Query) returns incorrect results when canTransact() returns false geotools/geotools#2645 which will probably resolve important issue In Shapefile layers, uncommitted features are affected by all operations. #348
• changes applied via [GEOT-6397] provide extra comparison method for featureTypes in DataUtilities class geotools/geotools#2601 and [GEOT-4931] Fix comparison of attribute bindings in DataUtilities geotools/geotools#2525 which may affect udig Improvements related to bulk feature copy or move between layers #218 enhancement leading to certain code modifications to restore its expected behavior.

[fgdrf]

Actually @jodygarnett wrote something in GeoTools mailing list, that 22.1 is not "valid". I guess we should move on to 22.2 once it is avalable.

The prior 22.1 build was one of those that failed over JDK issues so we only have partially

I'm not really sure about the statement, itf its a good idea to upgrade to 22.2 anyway:

I accidentally made a 22.2 release, see user list for discussion about renaming those folders to 22.2-mistake to avoid causing problems downstream

@jodygarnett can you give us any advice how to proceed with 22.x series?

[jodygarnett]

ha ha, I screwed up so bad and different development teams around the world are all confused :P

The https://sourceforge.net/projects/geotools/files/GeoTools%2022%20Releases/22.1/ release is the latest.

I just typed the wrong version number into the release script :P

[fgdrf]

ha ha, I screwed up so bad and different development teams around the world are all confused :P

The https://sourceforge.net/projects/geotools/files/GeoTools%2022%20Releases/22.1/ release is the latest.

I just typed the wrong version number into the release script :P

Can happen :) However, are you saying that 22.1 is fine?

[jodygarnett]

I have updated the release announcement to help make this clear: https://geotoolsnews.blogspot.com/2019/11/geotools-221-released.html

Update: Jody would like to apologize for accidentally releasing "22.2" while testing out JDK versions above. The maven repository folders have been renamed "22.2-mistake" to avoid causing problems. GeoTools 22.2 is scheduled for January.

Sorry for the trouble.

[fgdrf]

Thank you for clarification! IMO my pull for @egouge (see egouge#4) is still valid (which upgrades to 22.1)

[nprigour]

Ok @fgdrf,
I was not aware of your latest pull to @egouge branch :)

[fgdrf]

forgot to mentioned yet, my fault. @egouge Thanks for merging! Pre-flight Test looks good (at least on windows)

[fgdrf]

Cool, all active tests passed :D (see travis build)