upgrate to Eclipse 2019-03 to support Java 11#378
Merged
Conversation
- leads to unsupported 32bit environments (due to Eclipse 4.10) - target compile level still 1.8 - runs with both jre 1.8 and 11 Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Contributor
Author
|
@moovida Could you check the product build on Mac OSX to verify materialized product starts successfully? Much appreciated! |
Contributor
|
@fgdrf , just to be sure. I build this with java > 9 to see if the build finishes and generates the artifacts, right? |
Contributor
Author
|
@moovida Yeah, build it (with -Ptest Profile would be great) and run it with JRE >= 9 ( compile and target level are still 1.8 but runtime support comes with the newer Eclipse runtime). Many thanks in advance! |
Contributor
|
I am having test failures: |
Contributor
|
Sorry, forgot to update. This is the issue running the -Ptest profile: |
Contributor
Author
Thank you for your effort! I'm wondeing about win32:win32:x86 combination mentioned in out. Since we removed 32bit support from target-platform-configuration this should not happen anymore. Could you please check root-pom file environments section, it should look like this, otherwise you haven't checked out changes from this pull request (or a merge went not so well) HTH |
Contributor
|
Oh my @fgdrf , apologies, I indeed didn't check out the branch at all. :-( Doing it now. |
Contributor
|
Nope @fgdrf , I am afraid it still doesn't work: Also checked the environment part and it looks like yours. |
Contributor
Author
|
Output How did you check out the pull-request branch? |
Contributor
|
I followed the commandline instructions: Regarding win32, it is os and ws, not the arch, so it reflects the pom: |
Contributor
Author
|
@moovida Have you build on Linux or MacOSX? I assume order of environments for target-platform-configuration has an effect on the test execution. Since win32:win32:x86_64 is at the very beginning it is used... I'm wondering a bit about Travis builds which are mostly fine .. I'll check this |
os-specific to load libs for tests for platform where the build has been started Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Contributor
|
Hi @fgdrf , just ran it with I get a test failure at issues, but most of the tests went through well: |
Contributor
Author
can you test with option --fail-at-end too, to see potential failing tests of skipped modules ..? I just saw that travis build failed due to tha fact that Boundless Maven repository is down... I'll provide another fix w/o boundless repo configuration (mainly for pom-libs.xml build step) |
Signed-off-by: Frank Gasdorf <fgdrf@users.sourceforge.net>
Contributor
|
Ah @fgdrf , yesterday I ran the test and then I forgot about it. At some point I closed the terminal it seems :-/ |
Contributor
|
Good new @fgdrf , issues is the only one to fail: |
Contributor
Author
|
@moovida I'd prefer to merge it to master and file an issue for the failed test (with details about the platform where it might happen). Travis build and windows builds are fine so I see no blocker. I assume you can start uDig on macOSX from this branch and therefore uDig is java 11 ready, isn't it? I'd like to create a 2.2.0.RC1 once this changeset has been merged ;) |
Contributor
|
Yep, build is ok. Good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Frank Gasdorf fgdrf@users.sourceforge.net