[@docs] add Scroller styles API data#8818
Merged
rtivital merged 1 commit intoApr 7, 2026
Merged
Conversation
The Scroller component is declared as having a Styles API tab in the docs metadata, but @docs/styles-api had no ScrollerStylesApi entry, so /core/scroller?t=styles-api was not loading. Add the data file with selectors, CSS variables, and modifiers that match the actual Scroller implementation, and export it from the package index. Selectors, vars, and modifiers were verified against: - ScrollerStylesNames type in Scroller.tsx - ScrollerCssVariables type and varsResolver in Scroller.tsx - data-draggable on the container, data-position and data-hidden on the control buttons in Scroller.tsx Closes mantinedev#8817
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8817
Problem
The
Scrollercomponent page (/core/scroller?t=styles-api) wasnot loading the Styles API tab. The component is declared as having
a Styles API in the docs metadata, but
@docs/styles-apihad noScrollerStylesApientry.Fix
Add
packages/@docs/styles-api/src/data/Scroller.styles-api.tsandexport it from
packages/@docs/styles-api/src/index.ts.Verification
All entries match the actual
Scrollercomponent implementation:Selectors match
ScrollerStylesNamestype:```ts
export type ScrollerStylesNames =
'root' | 'container' | 'content' | 'control' | 'chevron';
```
CSS variables match
ScrollerCssVariablesandvarsResolver:```ts
export type ScrollerCssVariables = {
root: '--scroller-control-size' | '--scroller-background-color';
};
```
Modifiers match the actual data attributes in
Scroller.tsx:data-draggable={draggable || undefined}on the containerdata-position="start" | "end"on the control buttonsdata-hidden={!show... || undefined}on the control buttonsTesting
oxfmt --checkpasses for both modified fileslocally due to internal package setup issues unrelated to this
change (
@mantinex/*packages and other@docs/*workspacesfail to resolve in my local environment). Will rely on CI for
full type/build verification, since the change is scoped to
adding a single docs data file and one re-export.