JSON & misc cleanup#1234
Merged
Merged
Conversation
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Rename `mappingKeys` as `normalized`. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…bleURL` as `invalidURL`; update their error messages. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…<JSON.Object>`. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
|
There was a problem hiding this comment.
Code Review
This pull request updates the Periphery version to 3.7.4 and refactors JSON handling and model initialization. Key updates include renaming capitalizingFirstCharacter to uppercasingFirst, consolidating error types into invalidURL and invalidJSON, and introducing a ThrowingLazy utility for thread-safe, fallible lazy initialization. The CatalogApp and InstalledApp models now use a consistent normalization process for JSON keys, and the mas shell script was refactored to streamline jq logic across the outdated, search, and list commands. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSON & misc cleanup.
Resolve #1233