Misc cleanup#1236
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates SwiftFormat to version 0.61.1 and refactors the versioning utility logic by splitting the monolithic Version+SemVer.swift into modular files and protocols. It also standardizes command file headers, updates script function naming, and refines linting configurations. Feedback is provided regarding multiple instances of force unwrapping in Sources/mas/, which violates the project's engineering standards; specifically, static URLs and regex matches should be handled more safely using failable initializers or guards.
bf642e8 to
09523ef
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the project to SwiftFormat 0.61.1 and refactors the versioning utilities by splitting the monolithic Version+SemVer.swift into several modular files. It introduces a @required property wrapper for dependency management and refactors CatalogApp to use explicit URLs for API requests. Review feedback identifies a logic error in semantic version comparison where release versions were incorrectly ranked lower than pre-releases and recommends returning nil instead of using preconditionFailure within a failable initializer.
09523ef to
75445a5
Compare
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…ter. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…essibleByStringLiteral`. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
75445a5 to
3413fa3
Compare
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates project dependencies, including SwiftFormat and the GitHub CLI, and refactors the versioning utility logic by splitting the monolithic Version+SemVer.swift into several modular files. It introduces a new @required property wrapper for dependency management and updates CatalogApp to utilize configurable URLs. Additionally, file header comments have been standardized across the codebase, and various SwiftFormat/SwiftLint directives were adjusted. I have no feedback to provide as no review comments were present.
Misc cleanup.
Resolve #1235