Skip to content

chore: remove redundant sas token from public test file#2462

Merged
ranadeepsingh merged 1 commit into
microsoft:masterfrom
BrendanWalsh:brwals/removesas
Jan 13, 2026
Merged

chore: remove redundant sas token from public test file#2462
ranadeepsingh merged 1 commit into
microsoft:masterfrom
BrendanWalsh:brwals/removesas

Conversation

@BrendanWalsh

Copy link
Copy Markdown
Collaborator

These SAS tokens are redundant as the underlying file is already public. They are also inconvenient because static analysis tools flag them as a hazard.

@github-actions

Copy link
Copy Markdown

Hey @BrendanWalsh 👋!
Thank you so much for contributing to our repository 🙌.
Someone from SynapseML Team will be reviewing this pull request soon.

We use semantic commit messages to streamline the release process.
Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix.
This helps us to create release messages and credit you for your hard work!

Examples of commit messages with semantic prefixes:

  • fix: Fix LightGBM crashes with empty partitions
  • feat: Make HTTP on Spark back-offs configurable
  • docs: Update Spark Serving usage
  • build: Add codecov support
  • perf: improve LightGBM memory usage
  • refactor: make python code generation rely on classes
  • style: Remove nulls from CNTKModel
  • test: Add test coverage for CNTKModel

To test your commit locally, please follow our guild on building from source.
Check out the developer guide for additional guidance on testing your change.

@BrendanWalsh

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter

codecov-commenter commented Jan 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.41%. Comparing base (b7b6c78) to head (de96f24).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2462      +/-   ##
==========================================
- Coverage   84.42%   84.41%   -0.02%     
==========================================
  Files         335      335              
  Lines       17747    17747              
  Branches     1611     1611              
==========================================
- Hits        14983    14981       -2     
- Misses       2764     2766       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TomFinley TomFinley self-assigned this Jan 12, 2026

@TomFinley TomFinley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BrendanWalsh .

@BrendanWalsh

Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ranadeepsingh ranadeepsingh merged commit 4c45b9a into microsoft:master Jan 13, 2026
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants