fix: Remove overly tight polling timeout from AbstractiveSummarizationSuite#2493
Merged
Merged
Conversation
…nSuite AbstractiveSummarizationSuite explicitly set pollingDelay=5000ms and maxPollingRetries=30, giving only 2.5 minutes for the API to respond. This is insufficient for the Abstractive Summarization long-running operation, which can take longer under load, causing flaky TimeoutException failures. All other LRO test suites (ExtractiveSummarization, Healthcare, SentimentAnalysis, etc.) use the class defaults (pollingDelay=1000ms, maxPollingRetries=1000), which provides a much more generous timeout. Remove the explicit overrides so AbstractiveSummarizationSuite is consistent with the other LRO test suites.
|
Hey @BrendanWalsh 👋! We use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
To test your commit locally, please follow our guild on building from source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove explicit
pollingDelayandmaxPollingRetriesoverrides fromAbstractiveSummarizationSuiteto use the class defaults, consistent with all other LRO test suites.Problem
AbstractiveSummarizationSuiteexplicitly setpollingDelay=5000msandmaxPollingRetries=30, giving only 2.5 minutes for the Azure AI Language Abstractive Summarization API to respond. This is insufficient when the API is under load, causing flakyTimeoutExceptionfailures like build #20260208.1.All other LRO test suites (
ExtractiveSummarizationSuite,HealthcareSuite,SentimentAnalysisLROSuite, etc.) use the class defaults (pollingDelay=1000ms,maxPollingRetries=1000), providing a much more generous ~16 minute timeout.Fix
Remove the 3 pairs of
.setPollingDelay(5 * 1000)/.setMaxPollingRetries(30)calls soAbstractiveSummarizationSuiteuses the same defaults as every other LRO test suite.Validation
All 5 tests in
AbstractiveSummarizationSuitepass locally: