Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

fix multi-thread event handling issue#3899

Merged
QuanluZhang merged 1 commit into
microsoft:masterfrom
QuanluZhang:fix-retiarii-exp-bug
Jul 30, 2021
Merged

fix multi-thread event handling issue#3899
QuanluZhang merged 1 commit into
microsoft:masterfrom
QuanluZhang:fix-retiarii-exp-bug

Conversation

@QuanluZhang

@QuanluZhang QuanluZhang commented Jul 2, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • fix the bug that sometimes retiarii experiment cannot exit successfully after finishing all the trials, because nnimanager requests more trials from dispatcher/strategy
  • fix incorrect order of items for cleaning up retiarii experiment
  • fully test the modification

@QuanluZhang QuanluZhang mentioned this pull request Jul 5, 2021
Closed
ultmaster
ultmaster approved these changes Jul 7, 2021
View reviewed changes

@ultmaster ultmaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not confident of this approve, because I have no idea why it works now and why it didn't work before.

@QuanluZhang QuanluZhang requested a review from SparkSnail July 7, 2021 06:42
@QuanluZhang QuanluZhang merged commit 6645bd3 into microsoft:master Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@ultmaster ultmaster ultmaster approved these changes
@SparkSnail SparkSnail SparkSnail approved these changes
@liuzhe-lz liuzhe-lz liuzhe-lz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@QuanluZhang @ultmaster @SparkSnail @liuzhe-lz