Skip to content

Typo and formatting nitpicks#85

Merged
aeschli merged 2 commits into
microsoft:masterfrom
gilmoreorless:grammar-nitpicks
Oct 2, 2017
Merged

Typo and formatting nitpicks#85
aeschli merged 2 commits into
microsoft:masterfrom
gilmoreorless:grammar-nitpicks

Conversation

@gilmoreorless

Copy link
Copy Markdown
Contributor

Firstly, great work on the generator; it was really useful for converting a Sublime Text package over to VS Code.

This PR fixes some minor things that I noticed while using the generator. It has two main parts:

  1. Typos and grammatical nitpicks.
  2. Consistent capitalisation and punctuation in the bullet points of the various vsc-extension-quickstart.md files. The bullet points had a mixture of upper- and lower-case starting letters, and inconsistent application of full stops (periods).

I realise the second part is perhaps overly pedantic. If you’d rather accept just the typo fixes without the reformatting, I’m happy to redo the PR to suit (that’s why they’re separate commits 😉).

@aeschli aeschli merged commit b865288 into microsoft:master Oct 2, 2017
@aeschli

aeschli commented Oct 2, 2017

Copy link
Copy Markdown
Collaborator

Thanks @gilmoreorless , that was helpful!

@aeschli aeschli added this to the September 2017 milestone Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants