This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add a launch.json option to capture output from stdoutput and stderr streams#138
Merged
Conversation
|
@igelbox, |
roblourens
suggested changes
Sep 8, 2017
roblourens
left a comment
Member
There was a problem hiding this comment.
This is great, thanks!
When capturing stdout/err, I think it shouldn't show messages that come over the debug port, to avoid showing duplicate messages. Can you override onConsoleAPICalled to disable that in this case?
Contributor
Author
|
@roblourens thanks for your feedback. |
Member
|
You are quite right. Sorry, I misread... I will merge this tomorrow. |
roblourens
approved these changes
Sep 11, 2017
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help with microsoft/vscode#19750.
We'll just set
"outputCapture": "std",in the launch.json file.This approach is more lightweight than the original proposed
"console": "internalConsole"approach, which starts a separate shell process with (e.g. on my PC zsh with lots of plugins is started).