Error after dropping invalid element over editor area

[jeanp413]

• VS Code Version: stable and from sources

Steps to Reproduce:

[bpasero]

It looks like the raw dragged data is a UUID (e.g. "1fa3ce57-ce74-4ac8-a729-bb4d850eae15") and calling URI.parse on such a string returns a file URI, e.g. this:

URI.parse("foo")

results in this:

Uri {scheme: "file", authority: "", path: "/foo", query: "", fragment: "", …}

And we happily try to open such a URI because we always have a file system provider for files.

@isidorn fyi if that is intentional and @jrieken whether this is expected from the URI and whether I can figure this out upfront.

My workaround would be to ignore any strings that do not contain a : which hints at a string that does not seem to be a URI.

[isidorn]

@bpasero yes, we set the uri on purpose here. By the specs of the tree I need to have some uri for my element so it is draggable and that I can identify which element it is once it is dropped. I can of course change that URI to be something else if that will help.

[bpasero]

Ok understood, I now do this:

vscode/src/vs/workbench/browser/dnd.ts

Line 79 in 8887532

if (resourceRaw.indexOf(':') > 0) { // mitigate https://github.com/microsoft/vscode/issues/124946

But wonder if there is something else I could do...

[jeanp413]

@bpasero maybe we could:

1. Change the dataTransfer type in listview.ts from DataTransfers.RESOURCES to some other more generic type so DataTransfers.RESOURCES is used only for file resources
2. Validate the dataTransfer types in EditorDropTarget::onDragEnter with containsDragType(event, DataTransfers.FILES, CodeDataTransfers.FILES, DataTransfers.RESOURCES) so the drop overlay doesn't show up for invalid types

[isidorn]

@jeanp413 That's a good idea overall but would need adoption from all the listview clients, and there's quite a lot of them. fyi @joaomoreno for thoughts

[joaomoreno]

Fine by me.

[jeanp413]

Created PR #125943 fixing this.

I changed the dataTransfer type from DataTransfers.RESOURCES to DataTransfers.TEXT in listView.ts, let me know if that's ok.

That's a good idea overall but would need adoption from all the listview clients

Looking around dragAndDrop data is usually retrieved from IDragAndDropData instances and from dataTransfer.files. Am I missing something?