locate file:$line:$col in IntegratedTerminal

[boltyu]

Issue Type: Bug

by ctrl+leftclick to open a file in Terminal,
a path like xx/xxx/xx/xx.c could be open
and xx.c:13:3 could be open because recently opened, and auto jump to line/col
but a path with line/col number like xx/xxx/xx/xx.c:13:3 can't be open

VS Code version: Code 1.56.2 (054a929, 2021-05-12T17:13:13.157Z)
OS version: Windows_NT x64 10.0.19043
Remote OS version: Linux x64 5.4.72-microsoft-standard-WSL2

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz (6 x 2808)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	15.82GB (11.07GB free)
Process Argv	--crash-reporter-id 294b004d-0584-4bbe-931c-088a29372ec5
Screen Reader	no
VM	0%

Item	Value
Remote	WSL: Ubuntu-20.04
OS	Linux x64 5.4.72-microsoft-standard-WSL2
CPUs	Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz (2 x 2808)
Memory (System)	3.84GB (3.27GB free)
VM	0%

Extensions (7)

Extension	Author (truncated)	Version
remote-ssh	ms-	0.65.4
remote-ssh-edit	ms-	0.65.6
remote-wsl	ms-	0.56.4
vim	vsc	1.20.3
githistory	don	0.6.16
cpptools	ms-	1.4.0
hexeditor	ms-	1.6.0

[Tyriar]

Links of that form work, your issue is because you have the codec folder opened and files are only resolved relative to the root folder. So it would work fine if you opened the parent folder of codec. I guess we could special case this to remove the first path segment if it matches the opened folder (ie. the initial cwd of the terminal).

[Tyriar]

Code pointer: https://github.com/microsoft/vscode/blob/main/src/vs/workbench/contrib/terminal/browser/links/terminalWordLinkProvider.ts

[boltyu]

Links of that form work, your issue is because you have the codec folder opened and files are only resolved relative to the root folder. So it would work fine if you opened the parent folder of codec. I guess we could special case this to remove the first path segment if it matches the opened folder (ie. the initial cwd of the terminal).

Thanks for your reply, Its very helpful for me to understand that,
I add parent folder of codec to workspace, and it works as expect, much appreciated.

[mghalayini]

@Tyriar I suppose I can work on this. From what I understand, all I have to do is check if the prefix of the search query matches the root folder directory. If it does, we erase that first part and resume the code as usual, right?

[Tyriar]

@mghalayini pretty much yep, make sure it's a folder (link contains /, or \ on windows) and a test would be good too which should be fairly easy to write in the existing test file.

[mghalayini]

@Tyriar I checked the code pointer that you sent above, but it doesn't seem like it points to the right place (this is my first time navigating the VS Code repository so there's a good chance that I'm wrong). I did some research and ended up in "anythingQuickAccess.ts", specifically getFileSearchResults. I added one line (just to make sure I'm in the right place) that logs a message to the console whenever the user enters a new character in Quick Open, and it worked. Isn't that where I should be working? How is the terminal related to this issue?

[Tyriar]

@mghalayini we wouldn't want to change the quick access code but what the terminal sends to it:

vscode/src/vs/workbench/contrib/terminal/browser/links/terminalWordLinkProvider.ts

Line 149 in c5bbe0a

this._quickInputService.quickAccess.show(link);