Skip to content

Implement Pseudoterminal.onDidChangeName#115276

Merged
Tyriar merged 10 commits into
microsoft:mainfrom
habibkarim:hbibkrim/114898_terminal_name_change_event
May 4, 2021
Merged

Implement Pseudoterminal.onDidChangeName#115276
Tyriar merged 10 commits into
microsoft:mainfrom
habibkarim:hbibkrim/114898_terminal_name_change_event

Conversation

@habibkarim

@habibkarim habibkarim commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

This PR fixes #114898

@ghost

ghost commented Jan 28, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@jrieken jrieken assigned Tyriar and unassigned jrieken Jan 28, 2021
Tyriar
Tyriar suggested changes Jan 28, 2021
View reviewed changes
Comment thread src/vs/vscode.proposed.d.ts Outdated
@Tyriar Tyriar added this to the February 2021 milestone Jan 28, 2021
@habibkarim habibkarim changed the title Add window.onDidChangeTerminalName proposed API Pseudoterminal.onDidChangeName Feb 1, 2021
@habibkarim habibkarim changed the title Pseudoterminal.onDidChangeName Implement Pseudoterminal.onDidChangeName Feb 1, 2021
habibkarim
habibkarim commented Feb 1, 2021
View reviewed changes
Comment thread src/vs/workbench/api/common/extHostTerminalService.ts
habibkarim
habibkarim commented Feb 1, 2021
View reviewed changes
Comment thread src/vs/workbench/contrib/terminal/browser/terminalProcessExtHostProxy.ts Outdated
Tyriar
Tyriar reviewed Feb 1, 2021
View reviewed changes

@Tyriar Tyriar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, I'll bring this up at the API sync tomorrow so we can hopefully move forward with this

@joaomoreno joaomoreno changed the base branch from master to main February 15, 2021 08:51
@Tyriar Tyriar modified the milestones: February 2021, March 2021 Feb 16, 2021
@Tyriar Tyriar modified the milestones: March 2021, April 2021 Mar 22, 2021
@Tyriar

Tyriar commented Mar 22, 2021

Copy link
Copy Markdown
Contributor

Sorry about the delay, have to push this again

Tyriar
Tyriar suggested changes Apr 1, 2021
View reviewed changes
Comment thread src/vs/workbench/contrib/terminal/browser/terminalProcessExtHostProxy.ts Outdated
Comment thread src/vs/workbench/api/browser/mainThreadTerminalService.ts
Tyriar
Tyriar approved these changes Apr 1, 2021
View reviewed changes

@Tyriar Tyriar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, should be able to get this into proposed for the April release 🙂

@Tyriar Tyriar enabled auto-merge April 1, 2021 14:46
@Tyriar Tyriar modified the milestones: April 2021, May 2021 Apr 28, 2021
@Tyriar

Tyriar commented May 4, 2021

Copy link
Copy Markdown
Contributor

Didn't make April unfortunately, I missed the auto merge CI failure.

@Tyriar Tyriar merged commit 08e0907 into microsoft:main May 4, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Tyriar Tyriar Tyriar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Tyriar Tyriar

Labels

None yet

Projects

None yet

Milestone

May 2021

Development

Successfully merging this pull request may close these issues.

[ext-api] provide Pseudoterminal.onDidChangeName event

3 participants

@habibkarim @Tyriar @jrieken