Skip to content

Fix setting the debug call stack display for exceptions#123726

Merged
isidorn merged 4 commits into
microsoft:mainfrom
suzmue:hoverText
May 14, 2021
Merged

Fix setting the debug call stack display for exceptions#123726
isidorn merged 4 commits into
microsoft:mainfrom
suzmue:hoverText

Conversation

@suzmue

@suzmue suzmue commented May 12, 2021

Copy link
Copy Markdown
Contributor

This PR fixes #123724

@ghost

ghost commented May 12, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@suzmue

suzmue commented May 12, 2021

Copy link
Copy Markdown
Contributor Author

Here is a screenshot of the callstack ui on an exception:

Screen Shot 2021-05-12 at 6 55 25 PM

@suzmue

suzmue commented May 13, 2021

Copy link
Copy Markdown
Contributor Author

Here is a screenshot for the multithreaded case:
Screen Shot 2021-05-13 at 10 47 51 AM

@isidorn isidorn added this to the May 2021 milestone May 14, 2021
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 14, 2021
@isidorn

isidorn commented May 14, 2021

Copy link
Copy Markdown
Collaborator

This looks great. Thanks a lot for fixing this 👏 ☀️
Merging it in. I will just compress the css rules to be two selectors instead of four via f8a3cef

@isidorn isidorn merged commit 828e83d into microsoft:main May 14, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call stack UI for exception hover info and badge color

2 participants