Move profile resolving to pty service#123729
Merged
Merged
Conversation
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
Tyriar
commented
May 13, 2021
Collaborator
|
Think this was accidentally added? |
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
reviewed
May 13, 2021
meganrogge
approved these changes
May 13, 2021
Little nicer as default is false now
This felt a bit broken when using env.shell
This was referenced May 13, 2021
alexr00
reviewed
May 14, 2021
| } | ||
| const defaultProfile = await this.terminalProfileResolverService.getDefaultProfile({ | ||
| allowAutomationShell: true, | ||
| os: Platform.OS, |
Member
There was a problem hiding this comment.
@Tyriar Platform.OS could be the wrong OS if connected to a remote. Will getDefaultProfile ignore the wrong platform in that case?
Member
There was a problem hiding this comment.
Yep, tasks when connected to a remote are broken.
This was referenced May 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #122534
Fixes #123188
Fixes #123479
Fixes #123163
Fixes #123732
Fixes #121760
Related microsoft/vscode-python#16175
TODO: