Skip to content

add option to not show link hovers for terminal#124926

Merged
meganrogge merged 2 commits into
microsoft:mainfrom
nrayburn-tech:fix-113913
Jun 7, 2021
Merged

add option to not show link hovers for terminal#124926
meganrogge merged 2 commits into
microsoft:mainfrom
nrayburn-tech:fix-113913

Conversation

@nrayburn-tech

@nrayburn-tech nrayburn-tech commented May 30, 2021

Copy link
Copy Markdown
Contributor

Adds an option to disable showing link hovers in the terminal.

Testing

  1. Open a terminal and having a link inside of it. (echo "http://localhost:3000").
  2. Hover the link and see that a hover displays.
  3. Modify the setting terminal.integrated.showLinkHover to be false.
  4. Hover the link again and see that a hover does not display.

This PR fixes #113913 (comment), but not the entire issue of hovers not disappearing.

Fixes #125282

@Tyriar

Tyriar commented Jun 2, 2021

Copy link
Copy Markdown
Contributor

Created #125282 for this so it gets verified

@meganrogge

Copy link
Copy Markdown
Collaborator

Looks good, thank you for contributing 👍🏼

@meganrogge meganrogge merged commit 1a41c51 into microsoft:main Jun 7, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create setting to disable terminal hovers Terminal hover labels don't go away

4 participants