Skip to content

Add search.maxResults setting#126762

Merged
roblourens merged 2 commits into
microsoft:mainfrom
rickpmartin:configure-max-search-results
Jun 23, 2021
Merged

Add search.maxResults setting#126762
roblourens merged 2 commits into
microsoft:mainfrom
rickpmartin:configure-max-search-results

Conversation

@rickpmartin

Copy link
Copy Markdown

This PR fixes: #8563 by adding a setting search.maxResults which sets the maximum number of search results returned. null (empty) can be used to return unlimited results.

Notes:

Related issues:

Preview:

Below is a preview showing the new setting functionality, and also a replace of ~240,000 lines without issue.

vscode-max-search-results2

@ghost

ghost commented Jun 20, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@roblourens roblourens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Want to also change the default to 20,000? 🚀

I am just still hesitant about blowing up underpowered machines. But I think 20k would be fine and we still have some time to get feedback in insiders before the next release.

@roblourens roblourens added this to the June 2021 milestone Jun 22, 2021
@rickpmartin

Copy link
Copy Markdown
Author

Sure thing, I've updated the default value to 20000.

I'm not sure if this is important but there are workflows awaiting approval as they require a maintainer to approve them. Is that something you are able to do?

@roblourens roblourens merged commit ee82cd3 into microsoft:main Jun 23, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate removing Max results limitation for Search and replace results

2 participants