Add search.maxResults setting#126762
Merged
roblourens merged 2 commits intoJun 23, 2021
Merged
Conversation
roblourens
approved these changes
Jun 22, 2021
roblourens
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Want to also change the default to 20,000? 🚀
I am just still hesitant about blowing up underpowered machines. But I think 20k would be fine and we still have some time to get feedback in insiders before the next release.
Author
|
Sure thing, I've updated the default value to 20000. I'm not sure if this is important but there are workflows awaiting approval as they require a maintainer to approve them. Is that something you are able to do? |
This was referenced Jul 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes: #8563 by adding a setting
search.maxResultswhich sets the maximum number of search results returned.null(empty) can be used to return unlimited results.Notes:
Related issues:
Preview:
Below is a preview showing the new setting functionality, and also a replace of ~240,000 lines without issue.