Skip to content

Set top level stopped reason when threadId not specified#126852

Merged
isidorn merged 2 commits into
microsoft:mainfrom
suzmue:toplevel
Jun 25, 2021
Merged

Set top level stopped reason when threadId not specified#126852
isidorn merged 2 commits into
microsoft:mainfrom
suzmue:toplevel

Conversation

@suzmue

@suzmue suzmue commented Jun 21, 2021

Copy link
Copy Markdown
Contributor

In DAP, the threadID for a stopped event is optional. The stopped
reason and text should be displayed at the top level if the thread
id is not included.

This PR fixes #124532

@weinand weinand assigned isidorn and unassigned weinand Jun 21, 2021
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jun 21, 2021
@weinand weinand added this to the June 2021 milestone Jun 21, 2021
@suzmue

suzmue commented Jun 21, 2021

Copy link
Copy Markdown
Contributor Author

One Debug Session:
Screen Shot 2021-06-21 at 6 32 04 PM

Multiple Debug Sessions:
Screen Shot 2021-06-21 at 6 33 02 PM

@isidorn

isidorn commented Jun 25, 2021

Copy link
Copy Markdown
Collaborator

This is great work, I just review it and tried it out.
Thanks a lot for this PR, merging in 👏 ☀️

@isidorn isidorn merged commit a9d716d into microsoft:main Jun 25, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display top-level stop reason when StoppedEvent specifies no threadId

3 participants