Skip to content

Default Markdown language configuration#28172

Merged
mjbvz merged 2 commits into
microsoft:masterfrom
yzhang-gh:master
Jun 7, 2017
Merged

Default Markdown language configuration#28172
mjbvz merged 2 commits into
microsoft:masterfrom
yzhang-gh:master

Conversation

@yzhang-gh

Copy link
Copy Markdown
Contributor

Changes

  • use new autoClosingPairs grammar
  • add `, <> to autoClosingPairs
  • add surroundingPairs

@msftclas

msftclas commented Jun 7, 2017

Copy link
Copy Markdown

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mjbvz mjbvz added this to the June 2017 milestone Jun 7, 2017
@mjbvz mjbvz merged commit fc2b063 into microsoft:master Jun 7, 2017
@mjbvz

mjbvz commented Jun 7, 2017

Copy link
Copy Markdown
Contributor

Thanks! Should be in the next VScode 1.14 insiders build once those start up again

@mjbvz

mjbvz commented Jun 7, 2017

Copy link
Copy Markdown
Contributor

I think we need to remove ` as an autoclosing pair. It makes typing fenced code blocks pretty annoying

mjbvz pushed a commit that referenced this pull request Jun 7, 2017
Having ` as an autoclosing pair makes typing fenced code blocks annoying

#28172 (comment)
@yzhang-gh

Copy link
Copy Markdown
Contributor Author

agree with you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants