Replace bash shebang with '#!/usr/bin/env bash" for portability

[ultimaweapon]

The example system that does not put bash in a /bin directory is FreeBSD. Instead, they put it inside /usr/local/bin.

[msftclas]

All CLA requirements met.

[joaomoreno]

There is no Electron for FreeBSD.

Did you hit some actual issue?

[ultimaweapon]

I'm trying to port VS Code to FreeBSD. So, this PR is a first step.

[Tyriar]

This does seem to be the best for portability 👍 https://stackoverflow.com/a/10383546/1156119

[joaomoreno]

Thanks!

[joaomoreno]

@Tyriar This broke your publish scripts:

2017-09-25T05:22:58.0228590Z *****************************************************************************
2017-09-25T05:22:58.0248040Z Start: Publish to repositories
2017-09-25T05:22:58.0267650Z *****************************************************************************
2017-09-25T05:22:58.0295740Z /usr/bin/env: bash -e: No such file or directory

This is why I don't like PRs which don't fix an actual problem. Reverted that file: d99c7d8

[Tyriar]

I reverted the remainder of this commit in e29c517, it caused issues with Lintian on the deb package: #35638

[ultimaweapon]

Sorry for the problems. I will investigate these problems later when I have free time.

[julie-is-late]

not sure if you figured this out already, but #!/usr/bin/env has issues when you try to give the commands arguments like your bash -e from above. I've run into it before trying to do something like #!/usr/bin/env awk -f. It likes to try to parse all of the arguments together as one input to env, almost like it's making a call similar to env "$@" and mashing everything together. This is at least the case with GNU coreutils' env, it's reported to work on BSD, not that that's much help here though.
It looks like you already caught it in d99c7d8

[Tyriar]

@jshap70 that was the first problem that was hit