examples: add context7 component in Rust#306
Merged
Merged
Conversation
thomastaylor312
approved these changes
Oct 2, 2025
thomastaylor312
left a comment
Collaborator
There was a problem hiding this comment.
Great addition! Because this is an example, none of these are blocking
| match make_request(Method::Get, &endpoint, None, get_api_key().as_deref()) { | ||
| Ok(body) => { | ||
| let body_trimmed = body.trim(); | ||
| if body_trimmed.is_empty() || NO_CONTENT_MESSAGES.iter().any(|msg| body_trimmed == *msg) { |
Collaborator
There was a problem hiding this comment.
Nit: this could just be NO_CONTENT_MESSAGES.contains(body_trimmed)
| .set_authority(Some(CONTEXT7_HOST)) | ||
| .map_err(|_| "Failed to set authority".to_string())?; | ||
|
|
||
| let mut path = String::with_capacity(BASE_PATH.len() + endpoint.len() + 1); |
Collaborator
There was a problem hiding this comment.
Nit: Document the magic number
| } | ||
| } | ||
|
|
||
| fn make_request( |
Collaborator
There was a problem hiding this comment.
If you don't want to do all of this low level http code, consider importing https://docs.rs/wasmcloud-component/latest/wasmcloud_component/http/index.html. It has all the convenience wrappers around the http request stuff so you can just build requests and read responses using std::io::Read
Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
…xt7 implementation Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
4d8a96a to
87f3b68
Compare
… and remove unused serde dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiaxiao Zhou duibao55328@gmail.com