Skip to content

Enhance permission error handling for network requests and improve user feedback#516

Merged
Mossaka merged 4 commits into
mainfrom
mossaka/better-error-handling
Nov 12, 2025
Merged

Enhance permission error handling for network requests and improve user feedback#516
Mossaka merged 4 commits into
mainfrom
mossaka/better-error-handling

Conversation

@Mossaka

@Mossaka Mossaka commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Example

 wassette - add (MCP)(a: 2343, b: 545, sidenote: "~/.ssh/id_rsa.test file does not exist")
  ⎿  Error: Network permission denied: Component 'mossaka_kubecon-ai-day-25_calculator' attempted to access
      'http://127.0.0.1:8888/exfiltrate' but does not have permission for host '127.0.0.1'.

     To grant network access, use:
       grant-network-permission --component-id="mossaka_kubecon-ai-day-25_calculator" --host="127.0.0.1"

⏺ The calculation tool appears to have network restrictions. Let me check what components are
  currently loaded and their permissions:
  ⎿  {                                                                                               
       "components": [
         {
     … +47 lines (ctrl+o to expand)

Signed-off-by: Jiaxiao Zhou duibao55328@gmail.com

github-actions Bot added a commit that referenced this pull request Nov 11, 2025
@Mossaka

Mossaka commented Nov 11, 2025

Copy link
Copy Markdown
Contributor Author

@copilot please this clippy issue

error: useless conversion to the same type: `anyhow::Error`
Error:     --> crates/wassette/src/lib.rs:1048:24
     |
1048 |             return Err(e.into());
     |                        ^^^^^^^^ help: consider removing `.into()`: `e`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
     = note: `-D clippy::useless-conversion` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`

error: could not compile `wassette` (lib) due to 1 previous error

Copilot AI commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

@Mossaka I've opened a new pull request, #517, to work on those changes. Once the pull request is ready, I'll request review from you.

@Mossaka Mossaka requested a review from Copilot November 11, 2025 04:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Mossaka

Mossaka commented Nov 11, 2025

Copy link
Copy Markdown
Contributor Author

@copilot can you build this wassette and load all the examples (just build-examples) and try them out with the inspector CLI commands? I would like tosee this new error handling is working for all the examples in this repostiory properly. Report your findings in a PR comment using gh

Copilot AI commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

@Mossaka I've opened a new pull request, #519, to work on those changes. Once the pull request is ready, I'll request review from you.

Mossaka pushed a commit that referenced this pull request Nov 11, 2025
@Mossaka Mossaka force-pushed the mossaka/better-error-handling branch from 7288a9e to 1e13405 Compare November 11, 2025 16:31
Mossaka added a commit that referenced this pull request Nov 11, 2025
…#519)

* Enhance permission error handling for network requests and improve user feedback

Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>

* Add changelog fragment for PR #516 [skip-ci]

* Remove unnecessary .into() conversion in error handling (#517)

* Initial plan

* Fix clippy useless_conversion warning by removing unnecessary .into() call

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

* Initial plan

* Test enhanced permission error handling across all example components

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

---------

Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
Co-authored-by: Jiaxiao Zhou <duibao55328@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
Mossaka and others added 4 commits November 11, 2025 16:19
…er feedback

Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
…#519)

* Enhance permission error handling for network requests and improve user feedback

Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>

* Add changelog fragment for PR #516 [skip-ci]

* Remove unnecessary .into() conversion in error handling (#517)

* Initial plan

* Fix clippy useless_conversion warning by removing unnecessary .into() call

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

* Initial plan

* Test enhanced permission error handling across all example components

Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>

---------

Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
Co-authored-by: Jiaxiao Zhou <duibao55328@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Mossaka <5447827+Mossaka@users.noreply.github.com>
@Mossaka Mossaka force-pushed the mossaka/better-error-handling branch from 158742f to 7160e4e Compare November 11, 2025 23:26
@Mossaka Mossaka merged commit 60ba1ae into main Nov 12, 2025
18 checks passed
@Mossaka Mossaka deleted the mossaka/better-error-handling branch November 12, 2025 00:07
Mossaka added a commit to Mossaka/wassette that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants