fix: resolve SourcePackages path for Xcode 26#256
Merged
mono0926 merged 2 commits intoMay 14, 2026
Merged
Conversation
Validates that both GenerateAcknowledgementsCommand and LicensePlistBuildTool correctly resolve the SourcePackages directory from pluginWorkDirectoryURL on both old Xcode (<=16.2) and new Xcode (>=16.3 / Xcode 26) directory layouts. Ref: mono0926#251
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lastPathComponentguard fromLicensePlistBuildTool(Workaround for SourcePackages directory on Xcode 16.3 #241) toGenerateAcknowledgementsCommand, which was still using the old hard-coded 2-level ascentappending(component:)withappendingPathComponent(_:)in the build tool plugin for broader macOS SDK compatibilityStarting from Xcode 16.3,
pluginWorkDirectoryURLpoints toBuild/Intermediates.noindex/CommandPluginIntermediates/instead ofSourcePackages/plugins/. The command plugin was not updated in #241 and fails to find packages.Ref: #251
Test plan
swift buildpassesSourcePackages/on old and new Xcode layouts