Skip to content

[WIP] cmake: update to 3.5.2#584

Closed
mati865 wants to merge 1 commit into
msys2:masterfrom
mati865:cmake
Closed

[WIP] cmake: update to 3.5.2#584
mati865 wants to merge 1 commit into
msys2:masterfrom
mati865:cmake

Conversation

@mati865

@mati865 mati865 commented May 1, 2016

Copy link
Copy Markdown
Collaborator

It's still WIP but seems to be working. I've modified patches instead of recreating to make comparing easier. When it's ready to merge I'll recreate cmake-3.2.3-msys.patch to remove any fuzz.
It was tested by compiling doxygen, jsoncpp, nano. nano also have been manually tested. I know these 3 packages aren't enough to prove cmake is fine. How can I test if cmake is working as expected?

@mingwandroid

Copy link
Copy Markdown
Member

Build https://github.com/Alexpux/MSYS2-packages/tree/master/clang-svn .. or if that fails and you can't fix it, find other msys2 packages that use CMake. I'd check but I'm not at a computer.

@mati865

mati865 commented May 1, 2016

Copy link
Copy Markdown
Collaborator Author

Ok, I'll try it tomorrow. I don't want you to waste too much time since you are busy already.

@mingwandroid

Copy link
Copy Markdown
Member

It may need some updates unrelated to the CMake version change. I'll try to help out if that's the case.

@mati865

mati865 commented May 2, 2016

Copy link
Copy Markdown
Collaborator Author

Right now it's compiling. I've had to make some workarounds which will probably break clang.
They can be found here: mati865@0a27fbf
Note about 0001-cmake-hack-for-msys2.patch

For some reason CYGWIN is false under a MSYS Environment when using a msys compiler
A MSYS2 compiler is essentially cygwin compiler so this should be set to true.

Before anyone point out cmake's MSYS variable to me.
The MSYS variable refers to the host system and not the compiler.
So CYGWIN should still be TRUE.

This should be fixed in msys-cmake so that we can remove this patch :)

I guess it's + #set(CYGWIN 1) in cmake/cmake-3.2.3-msys.patch lines 80 and 100.

@mati865

mati865 commented May 2, 2016

Copy link
Copy Markdown
Collaborator Author

Build failed at 69% because of my mistake at modifying patches. Fixed patch pushed, I'll recompile it somewhen in following days.

@mati865

mati865 commented May 2, 2016

Copy link
Copy Markdown
Collaborator Author

Ok I managed to find some time to run compilation, clang, lld and llvm compiled. They are broken and I guess it's because of quick workarounds or some updates to source code. But it's up to you to decide what now @mingwandroid.

@mati865 mati865 mentioned this pull request May 20, 2016
@mati865 mati865 closed this May 23, 2016
dscho added a commit to dscho/MSYS2-packages that referenced this pull request May 20, 2025
Release notes (https://www.greenwoodsoftware.com/less/news.678.html):

Version 678 was released for beta testing on 2 May 2025, and was
released for general use on 17 May 2025.

These are the differences between [version
668](https://www.greenwoodsoftware.com/less/news.668.html) and version
678:

-   Treat -r in LESS environment variable as -R.
-   Add ESC-j and ESC-k commands ([github
    msys2#560](gwsw/less#560)).
-   Add --no-paste option ([github
    msys2#523](gwsw/less#523)).
-   Add --no-edit-warn option ([github
    msys2#513](gwsw/less#513)).
-   Add --form-feed option ([github
    msys2#496](gwsw/less#496)).
-   Add ESC-b command ([github
    msys2#615](gwsw/less#615)).
-   Make TAB complete option name in -- command ([github
    msys2#531](gwsw/less#531)).
-   Update the file size on an attempt to go past end of file.
-   Make -R able to pass through any OSC escape sequences, not just OSC
    8 ([github msys2#504](gwsw/less#504)).
-   Setting LESS_IS_MORE=0 now disables "more" compatibility even if
    invoked via a file link named "more" ([github
    msys2#500](gwsw/less#500)).
-   Pass through escape sequences in prompts even if -R is not set.
-   Add LESS_SHELL_LINES to support shell prompts which use more than
    one line ([github msys2#514](gwsw/less#514)).
-   Add LESSANSIOSCALLOW to define OSC types which may be passed
    through.
-   Add LESSANSIOSCCHARS to define non-standard OSC intro chars.
-   Add LESS_SIGUSR1 to define user signal handler ([github
    msys2#582](gwsw/less#582)).
-   Add mouse and mouse6 commands to lesskey ([github
    msys2#569](gwsw/less#569)).
-   Improve behavior of ^O^N and ^O^P commands.
-   Leave stty tabs setting unchanged ([github
    msys2#620](gwsw/less#620)).
-   Fix unexpected behavior when entering a partial command followed by
    a valid command ([github
    msys2#543](gwsw/less#543)).
-   Fix bug when coloring prompt string with SGR sequences ([github
    msys2#516](gwsw/less#516)).
-   Fix bug when searching for text near an invalid UTF-8 sequence
    ([github msys2#542](gwsw/less#542)).
-   Fix display bug when file contains ESC followed by NUL ([github
    msys2#550](gwsw/less#550)).
-   Fix bug when using +:n +:p +:x or +:d on the command line ([github
    msys2#552](gwsw/less#552)).
-   Fix bug with --no-number-headers when header is not at start of file
    ([github msys2#566](gwsw/less#566)).
-   Fix bug where lesstest fails if window is resized ([github
    msys2#570](gwsw/less#570)).
-   Fix bug using "configure --with-secure=no" ([github
    msys2#584](gwsw/less#584)).
-   Fix bug using multibyte command chars ([github
    msys2#595](gwsw/less#595)).
-   Fix auto_wrap setting on Windows ([github
    msys2#497](gwsw/less#497)).
-   Fix two bugs using ^S search modifier ([github
    msys2#605](gwsw/less#605)).
-   Fix bug searching for UTF-8 strings with the PCRE2 library ([github
    msys2#610](gwsw/less#610)).
-   Fix bug highlighting OSC 8 links when opening a new file.
-   Fix bug when & filtering is active ([github
    msys2#618](gwsw/less#618)).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
lazka pushed a commit that referenced this pull request May 20, 2025
Release notes (https://www.greenwoodsoftware.com/less/news.678.html):

Version 678 was released for beta testing on 2 May 2025, and was
released for general use on 17 May 2025.

These are the differences between [version
668](https://www.greenwoodsoftware.com/less/news.668.html) and version
678:

-   Treat -r in LESS environment variable as -R.
-   Add ESC-j and ESC-k commands ([github
    #560](gwsw/less#560)).
-   Add --no-paste option ([github
    #523](gwsw/less#523)).
-   Add --no-edit-warn option ([github
    #513](gwsw/less#513)).
-   Add --form-feed option ([github
    #496](gwsw/less#496)).
-   Add ESC-b command ([github
    #615](gwsw/less#615)).
-   Make TAB complete option name in -- command ([github
    #531](gwsw/less#531)).
-   Update the file size on an attempt to go past end of file.
-   Make -R able to pass through any OSC escape sequences, not just OSC
    8 ([github #504](gwsw/less#504)).
-   Setting LESS_IS_MORE=0 now disables "more" compatibility even if
    invoked via a file link named "more" ([github
    #500](gwsw/less#500)).
-   Pass through escape sequences in prompts even if -R is not set.
-   Add LESS_SHELL_LINES to support shell prompts which use more than
    one line ([github #514](gwsw/less#514)).
-   Add LESSANSIOSCALLOW to define OSC types which may be passed
    through.
-   Add LESSANSIOSCCHARS to define non-standard OSC intro chars.
-   Add LESS_SIGUSR1 to define user signal handler ([github
    #582](gwsw/less#582)).
-   Add mouse and mouse6 commands to lesskey ([github
    #569](gwsw/less#569)).
-   Improve behavior of ^O^N and ^O^P commands.
-   Leave stty tabs setting unchanged ([github
    #620](gwsw/less#620)).
-   Fix unexpected behavior when entering a partial command followed by
    a valid command ([github
    #543](gwsw/less#543)).
-   Fix bug when coloring prompt string with SGR sequences ([github
    #516](gwsw/less#516)).
-   Fix bug when searching for text near an invalid UTF-8 sequence
    ([github #542](gwsw/less#542)).
-   Fix display bug when file contains ESC followed by NUL ([github
    #550](gwsw/less#550)).
-   Fix bug when using +:n +:p +:x or +:d on the command line ([github
    #552](gwsw/less#552)).
-   Fix bug with --no-number-headers when header is not at start of file
    ([github #566](gwsw/less#566)).
-   Fix bug where lesstest fails if window is resized ([github
    #570](gwsw/less#570)).
-   Fix bug using "configure --with-secure=no" ([github
    #584](gwsw/less#584)).
-   Fix bug using multibyte command chars ([github
    #595](gwsw/less#595)).
-   Fix auto_wrap setting on Windows ([github
    #497](gwsw/less#497)).
-   Fix two bugs using ^S search modifier ([github
    #605](gwsw/less#605)).
-   Fix bug searching for UTF-8 strings with the PCRE2 library ([github
    #610](gwsw/less#610)).
-   Fix bug highlighting OSC 8 links when opening a new file.
-   Fix bug when & filtering is active ([github
    #618](gwsw/less#618)).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants