errors: add space between error name and code#12099
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
`Error[CODE]` becomes `Error [CODE]`
Member
seems like a |
gibfahn
approved these changes
Mar 28, 2017
4 tasks
lpinca
approved these changes
Mar 29, 2017
addaleax
approved these changes
Mar 29, 2017
evanlucas
approved these changes
Mar 29, 2017
evanlucas
left a comment
Contributor
There was a problem hiding this comment.
I feel like this is better. Thanks!
addaleax
approved these changes
Mar 31, 2017
Member
jasnell
added a commit
that referenced
this pull request
Apr 3, 2017
`Error[CODE]` becomes `Error [CODE]` PR-URL: #12099 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com>
Member
Author
|
Landed in 7b4a72d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error[CODE]becomesError [CODE]Depends on: #11220
/cc @Trott @evanlucas
(I'm not sure how to classify this on the semver scale since we have not actually used it yet)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors