build: fix RELEASE check (URGENT)#1421
Closed
rvagg wants to merge 1 commit into
Closed
Conversation
Member
Author
|
for reference, the error on a release build is: I was weary about this change and even went to the effort of testing the suggested |
Member
Author
|
meh, merging without review |
Member
Author
|
landed @ fa91b18 |
Member
|
For what its worth: post-merge LGTM. Sorry about the slip-up. |
Member
Author
|
still no good, on OSX: I don't even ... Makefiles :shakesfist: and cross-platform sed :shakesfist: |
rvagg
added a commit
to rvagg/io.js
that referenced
this pull request
Apr 14, 2015
Notable changes: * build: A syntax error in the Makefile for release builds caused 1.7.0 to be DOA and unreleased. (Rod Vagg) nodejs#1421.
Member
|
I can't reproduce. Tried on gnu make 3.81: # cat foo
all:
RELEASE=$(shell sed -ne 's/#define NODE_VERSION_IS_RELEASE \([01]\)/\1/p' src/node_version.h)
# make -f foo
RELEASE=0 |
Member
Author
|
force-pushed another fix in this from to it's now aee86a2 thanks @jbergstroem for spotting that as the problem |
rvagg
added a commit
that referenced
this pull request
Apr 14, 2015
Notable changes: * build: A syntax error in the Makefile for release builds caused 1.7.0 to be DOA and unreleased. (Rod Vagg) #1421
jasnell
added a commit
to nodejs/dev-policy
that referenced
this pull request
Apr 15, 2015
Add allowance for release time commits and error corrections. Per: #48 (comment) Example: nodejs/node#1421 and nodejs/node@fd90b33...50e9fc1.
dreamhigh0525
pushed a commit
to dreamhigh0525/dev-policy
that referenced
this pull request
Mar 9, 2023
Add allowance for release time commits and error corrections. Per: nodejs/dev-policy#48 (comment) Example: nodejs/node#1421 and nodejs/node@fd90b33...50e9fc1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #1405
please review @jbergstroem || @bnoordhuis asap or I'm just going to merge this and release a 1.7.1, 1.7.0 is a write-off because this is broken unfortunately.