test: replace assert.throws with common.expectsError#17498
test: replace assert.throws with common.expectsError#17498mithunsasidharan wants to merge 1 commit into
Conversation
|
@apapirovski @jasnell : Can I request if we could have this and other related PRs reviewed and landed sooner to avoid possible merge conflicts and changes resulting from other PRs ? |
|
This shouldn't be too likely to run into merge conflicts since it modifies pretty specific code. IMO it'll need the usual 48 hours to land. I'll review later today or tomorrow when I've got a moment. |
|
@apapirovski : Thanks a lot. Here's ref to all 6 PRs related to this.. https://github.com/nodejs/node/pulls/mithunsasidharan |
apapirovski
left a comment
There was a problem hiding this comment.
SGTM if the CI is green
|
@apapirovski : Can we have this and related PRs 17497, 17494,17484,17483 merged so that we can avoid potential merge conflict issues and its already been over 2 days ! Kindly advice. Thanks ! |
|
@mithunsasidharan Please try to avoid pinging re: merging PRs. Someone will merge a PR if it's ready when they have a moment. As you'll note, there are over 180 open PRs and most of us are volunteers. Also, strictly speaking only two of those PRs are over 48 hours old. This one still has another 4 hours to bake. |
|
@apapirovski : My sincere apologies. It was out of excitement and intend to avoid any possible merge conflict. I will keep up with the rules. Thanks again ! |
|
Would like to see a few more reviews for this so will wait to merge. If no one gets a chance to review in the next 24-48 hours, then will land as is. |
maclover7
left a comment
There was a problem hiding this comment.
LGTM, do your PRs cover all remaining assert.throws instances? Is there an ESLint rule that should be introduced here?
|
@maclover7 : The open PRs cover all remaining instances. Thanks ! |
|
@maclover7 I have a lint rule ready (it's in one of the Code & Learn threads and my gist account), will introduce it when I have a moment. |
|
Landed in eae0c05 |
PR-URL: #17498 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
PR-URL: #17498 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
PR-URL: #17498 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
|
If someone would like to backport this to v8.x-staging and v6.x-staging, please follow the guide and raise backport PRs. |
Refactored tests to replace
assert.throws(fn, common.expectsError(err));withcommon.expectsError(fn, err);Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test