Skip to content

feat(TS): add types for composed dispatchers#2967

Merged
mcollina merged 4 commits into
mainfrom
feat/interceptor-types
Mar 20, 2024
Merged

feat(TS): add types for composed dispatchers#2967
mcollina merged 4 commits into
mainfrom
feat/interceptor-types

Conversation

@metcoder95

@metcoder95 metcoder95 commented Mar 15, 2024

Copy link
Copy Markdown
Member

This relates to...

Adding missing types for Dispatcher#compose and ComposeDispatcher

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@codecov-commenter

codecov-commenter commented Mar 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (3be7ec9) to head (5935d68).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2967   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files          89       89           
  Lines       24171    24171           
=======================================
  Hits        22597    22597           
  Misses       1574     1574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread types/dispatcher.d.ts Outdated
@clovis-guillemot

clovis-guillemot commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Hello guys, is that could be merged asap please, I need it to avoid this warn 'UNDICI-CLIENT-INTERCEPTOR-DEPRECATED'

Migration from got to undici in progress 😀 🚀
Regards

Comment thread types/dispatcher.d.ts Outdated

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit a045e56 into main Mar 20, 2024
@KhafraDev KhafraDev deleted the feat/interceptor-types branch March 20, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

interceptors does not have any exported type

5 participants