Chore: run tests daily against node nightly#2969
Merged
Merged
Conversation
mweberxyz
commented
Mar 15, 2024
|
|
||
| jobs: | ||
| test: | ||
| if: github.repository == 'nodejs/undici' |
Contributor
Author
There was a problem hiding this comment.
Be kind to forks, only run in upstream repo.
| on: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: "0 10 * * *" |
Contributor
Author
There was a problem hiding this comment.
Most days the nightly lands between 7:30-9:30 - see dates here: https://nodejs.org/download/nightly/
Contributor
Author
|
Forgot to add:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2969 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 89 89
Lines 24171 24171
=======================================
Hits 22597 22597
Misses 1574 1574 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KhafraDev
approved these changes
Mar 16, 2024
Contributor
Contributor
Author
|
Thanks for the shout out! Also good news: this thing has been working -- https://github.com/nodejs/undici/actions/workflows/nightly.yml |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
#2932
Rationale
In order to catch regressions either caused by or a result of upstream Node changes, add a workflow that is invoked on a daily basis to run the
mainbranch's unit tests utilizing the most recent daily build.In the event of test failure, create a new issue if needed, otherwise comment the most recent open "Nightly tests are failing" issue with the most recent failure.
Changes
Node CIworkflownightlyworkflow, triggered on a daily schedule (or alternative, manually via workflow_dispatch to test changes in main without waiting for the next day's scheduled run.)Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status