Skip to content

align EventSource with spec#5418

Merged
mcollina merged 1 commit into
nodejs:mainfrom
KhafraDev:eventsource-credentials-include
Jun 13, 2026
Merged

align EventSource with spec#5418
mcollina merged 1 commit into
nodejs:mainfrom
KhafraDev:eventsource-credentials-include

Conversation

@KhafraDev

Copy link
Copy Markdown
Member

Claude, find a bug in undici then create an issue to waste maintainer's time

fixes #5378

@KhafraDev

Copy link
Copy Markdown
Member Author

(afaik there's no discernible behavior differences, so can't really write a test)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.35%. Comparing base (0d6ecc5) to head (2493c53).

Files with missing lines Patch % Lines
lib/web/eventsource/util.js 93.75% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5418      +/-   ##
==========================================
- Coverage   93.35%   93.35%   -0.01%     
==========================================
  Files         110      110              
  Lines       36928    36949      +21     
==========================================
+ Hits        34475    34494      +19     
- Misses       2453     2455       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina

Copy link
Copy Markdown
Member

if there is no difference why should we land this?

@KhafraDev

Copy link
Copy Markdown
Member Author

so we don't get more ai created issues that mention this as a bug

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e114e77 into nodejs:main Jun 13, 2026
60 of 67 checks passed
@github-actions github-actions Bot mentioned this pull request Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EventSource sets credentials to "omit" instead of "include" when withCredentials is true

3 participants