streamlines#6304
Merged
Merged
Conversation
nlf
approved these changes
Mar 29, 2023
nlf
suggested changes
Mar 29, 2023
nlf
left a comment
Contributor
There was a problem hiding this comment.
just double reviewing because it's the end of the day and i want to remember to re-review this in the morning when it's fixed
eed1f70 to
2de596a
Compare
Collaborator
|
no statistically significant performance changes detected timing results
|
Wrapping logging messages is very inacessible and makes for bad logs. We can let terminals wrap content. The whole cli.js file needs to parse, not just the single function checking for compatibility, so we inline it again.
2de596a to
fbb6e94
Compare
nlf
approved these changes
Mar 30, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see individual commits for details on each change