Don't exclude test directories#3
Merged
Merged
Conversation
Contributor
|
Weird, I seem to recall having some kind of reason for that, but it strikes me now as obviously wrong. Please do land this, lgtm, thank you. |
|
Thanks for this fix - due to an unusual design decision some time ago, some private repos I'm working in are sharing some tests by putting them into a shared package's In my particular case, I was able to add a .npmignore whitelist entry to the shared repo ( |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new exclusions to what goes in published artifacts is breaking for npm and the code this replaces didn't exclude tests by default.
The breakingness is definitely a judgement call. I wouldn't view adding more exclusions for gyp temp files or editor cruft as breaking, for example.