feat(cloudinary): support reading project from absolute url#1361
Merged
Conversation
Member
|
Would you be able to add an example to the test suite? 🙏 |
Contributor
Author
|
@danielroe - I have added an example to the test suite in cc86997 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1361 +/- ##
==========================================
+ Coverage 61.95% 63.20% +1.25%
==========================================
Files 79 79
Lines 3609 3615 +6
Branches 392 407 +15
==========================================
+ Hits 2236 2285 +49
+ Misses 1343 1301 -42
+ Partials 30 29 -1 ☔ View full report in Codecov by Sentry. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1376
Adds the ability for a full cloudinary url to be used as
srcinstead of relying onbaseURLto construct the image url.For example:
should use
https://res.cloudinary.com/example/image/uploadas thebaseURL, regardless of whatbaseURLis configured as.This is needed for apps that receive a full cloudinary url from the backend which may be responsible for determining the specific cloud and base url.
See discussion in Discord thread: https://discord.com/channels/473401852243869706/1238298456540577802