Skip to content

fix: update to latest @nuxt/module-builder#1439

Merged
danielroe merged 1 commit into
mainfrom
update-module-builder
Aug 25, 2024
Merged

fix: update to latest @nuxt/module-builder#1439
danielroe merged 1 commit into
mainfrom
update-module-builder

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Previous versions of @nuxt/module-builder produced incorrect types for files in the runtime/ directory. Specifically, a .d.ts declaration paired with a .mjs file. This isn't correct - it should be either .d.mts and .mjs or .d.ts and .js.

For maximum compatibility, @nuxt/module-builder v0.8 switched to .js extension for files in runtime/ directory.

With the latest Nuxt, this is now an error that removes correct plugin injection types.

Related PRs: nuxt/nuxt#28480, nuxt/nuxt#28593
See also nuxt/nuxt#28672.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: afd7163
Status: ✅  Deploy successful!
Preview URL: https://3bac3a5a.nuxt-image.pages.dev
Branch Preview URL: https://update-module-builder.nuxt-image.pages.dev

View logs

@codecov-commenter

codecov-commenter commented Aug 25, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.26%. Comparing base (052f9a9) to head (afd7163).
⚠️ Report is 576 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1439   +/-   ##
=======================================
  Coverage   62.26%   62.26%           
=======================================
  Files          79       79           
  Lines        3599     3599           
  Branches      397      397           
=======================================
  Hits         2241     2241           
  Misses       1328     1328           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe merged commit 3104213 into main Aug 25, 2024
@danielroe danielroe deleted the update-module-builder branch August 25, 2024 21:48
@github-actions github-actions Bot mentioned this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants