Skip to content

fix(ipx): always use ipx provider if external baseURL is provided#1800

Merged
danielroe merged 1 commit into
mainfrom
fix/external-ipx
Apr 6, 2025
Merged

fix(ipx): always use ipx provider if external baseURL is provided#1800
danielroe merged 1 commit into
mainfrom
fix/external-ipx

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

it's possible to use a self-hosted ipx instance and in this case we don't need to add an /_ipx handler. And we can support ipx even on non-node targets.

in such a case, this PR avoids setting up the handler and doesn't disable ipx outside a node environment.

@danielroe danielroe requested review from atinux and pi0 April 5, 2025 08:19
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Apr 5, 2025

Copy link
Copy Markdown

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3e093cc
Status: ✅  Deploy successful!
Preview URL: https://e151d6d4.nuxt-image.pages.dev
Branch Preview URL: https://fix-external-ipx.nuxt-image.pages.dev

View logs

@pkg-pr-new

pkg-pr-new Bot commented Apr 5, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@1800

commit: 3e093cc

@codecov-commenter

codecov-commenter commented Apr 5, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.89%. Comparing base (5dcaea2) to head (3e093cc).
⚠️ Report is 234 commits behind head on main.

Files with missing lines Patch % Lines
src/module.ts 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1800      +/-   ##
==========================================
- Coverage   62.91%   62.89%   -0.02%     
==========================================
  Files          81       81              
  Lines        3772     3776       +4     
  Branches      431      432       +1     
==========================================
+ Hits         2373     2375       +2     
- Misses       1371     1373       +2     
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe merged commit 393ec8a into main Apr 6, 2025
@danielroe danielroe deleted the fix/external-ipx branch April 6, 2025 14:16
This was referenced Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants