Skip to content

type the observable10 color scheme#1954

Merged
Fil merged 2 commits into
mainfrom
fil/type-observable10-scheme
Dec 21, 2023
Merged

type the observable10 color scheme#1954
Fil merged 2 commits into
mainfrom
fil/type-observable10-scheme

Conversation

@Fil

@Fil Fil commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@Fil Fil requested a review from mbostock December 21, 2023 11:45

@mbostock mbostock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the categorical schemes in sorted order though?

order, fix comment
@Fil

Fil commented Dec 21, 2023

Copy link
Copy Markdown
Contributor Author

Fixed the order (plus, I had missed the comment!)

@Fil Fil enabled auto-merge (squash) December 21, 2023 14:30
@Fil Fil merged commit ae6dcef into main Dec 21, 2023
@Fil Fil deleted the fil/type-observable10-scheme branch December 21, 2023 14:31
chaichontat pushed a commit to chaichontat/plot that referenced this pull request Jan 14, 2024
* type the observable10 color scheme
* order, fix comment
@dperetti

Copy link
Copy Markdown

Weird, I get this upgrading from 0.6.13 to 0.6.14
image

@mbostock

Copy link
Copy Markdown
Member

@dperetti You need to upgrade your transitive dependencies (e.g., npm update).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants