Symbolic links in dist tarball seem broken

[brucestephens]

For example in openssl-1.0.2e.tar.gz, openssl-1.0.2e/include/openssl/aes.h -> openssl-1.0.2e/../../crypto/aes/aes.h.

Probably this can be resolved by appending S to the --transform expression when forming the tarball.

[glensc]

same error is also in 0.9.8zh release:

$ tar tvfs openssl-0.9.8zh.tar.gz|grep test/jpaketest.c
lrwxrwxrwx openssl/openssl      0 2015-12-03 17:00 openssl-0.9.8zh/test/jpaketest.c -> openssl-0.9.8zh/dummytest.c

[glensc]

workaround for now:

ln -s . test/openssl-1.0.2e

[quanah]

STILL BROKEN IN LATEST RELEASE

[glensc]

@quanah i don't think they follow github tracker

i sent mail to rt@openssl.org as per http://openssl.org/community/, but the ticket haven't appeared in rt.openssl.org

[mattcaswell]

We do follow. What exactly is still broken? What problems are incorrect links causing?

[richsalz]

We do follow tracker. RT posts are moderated and the moderator(s) are busy re-packing the release.

[glensc]

@mattcaswell @richsalz symlinks in tarball point to in-existent files:

#491 (comment)

[glensc]

also, these files are missing in last tarball, but were present in previous version. i'm not sure is that intentional:

cp: cannot stat 'doc/openssl_button.gif': No such file or directory
cp: cannot stat 'doc/openssl_button.html': No such file or directory

[glensc]

broken symlinks make build failure of test files (make tests):

http://buildlogs.pld-linux.org//index.php?dist=th&arch=x86_64&ok=0&name=openssl&id=099b95db-969a-4d18-a32e-d0520ba189ed&action=tail#error-1

[richsalz]

The files were removed on purpose, but the script that refers them was apparently not fixed; a bug.

[glensc]

@richsalz the doc files are then okay.

we copy them to docdir in rpm packaging: https://github.com/pld-linux/openssl/blob/edee8d76233cfbf2c42a744721d2d522b29c44cb/openssl.spec#L413

so no bug there if removed intentionally