Replace node+npm+webpack by esbuild#4377
Merged
Merged
Conversation
|
neat |
mikl
reviewed
Jul 18, 2021
josevalim
commented
Jul 18, 2021
mveytsman
reviewed
Jul 18, 2021
Co-authored-by: Max Veytsman <maxim@ontoillogical.com>
cigrainger
reviewed
Jul 19, 2021
| ## The assets directory | ||
|
|
||
| The `assets` directory contains everything related to front-end assets, such as JavaScript, CSS, static images and more. It is typically handled by the [npm] tool. Phoenix developers typically only need to run `npm install` inside the assets directory. Everything else is managed by Phoenix. | ||
| The `assets` directory contains source files related to front-end assets, such as JavaScript and CSS. Since Phoenix v1.6, we use the [`esbuild`](https://github.com/evanw/esbuild/) to compile assets, which is managed by the [`esbuild`](https://github.com/phoenixframework/esbuild) Elixir package. The integration with `esbuild` is backed into your app. The relevant config can be found in your `config/config.exs` file. |
There was a problem hiding this comment.
Suggested change
| The `assets` directory contains source files related to front-end assets, such as JavaScript and CSS. Since Phoenix v1.6, we use the [`esbuild`](https://github.com/evanw/esbuild/) to compile assets, which is managed by the [`esbuild`](https://github.com/phoenixframework/esbuild) Elixir package. The integration with `esbuild` is backed into your app. The relevant config can be found in your `config/config.exs` file. | |
| The `assets` directory contains source files related to front-end assets, such as JavaScript and CSS. Since Phoenix v1.6, we use the [`esbuild`](https://github.com/evanw/esbuild/) to compile assets, which is managed by the [`esbuild`](https://github.com/phoenixframework/esbuild) Elixir package. The integration with `esbuild` is baked into your app. The relevant config can be found in your `config/config.exs` file. |
chrismccord
reviewed
Jul 19, 2021
chrismccord
reviewed
Jul 19, 2021
chrismccord
reviewed
Jul 19, 2021
chrismccord
approved these changes
Jul 19, 2021
|
|
||
| *Note:* the `--prefix` flag on `npm` may not work on Windows. If so, replace the first command by `cd assets && npm run deploy && cd ..`. | ||
|
|
||
| And that is it! The first command builds the assets and the second generates digests as well as a cache manifest file so Phoenix can quickly serve assets in production. |
There was a problem hiding this comment.
Now it's just a simple command, make sense to change it too?
josevalim
commented
Jul 19, 2021
Co-authored-by: Chris McCord <chris@chrismccord.com>
Member
Author
|
💚 💙 💜 💛 ❤️ |
sthagen
added a commit
to sthagen/phoenixframework-phoenix
that referenced
this pull request
Jul 19, 2021
Replace node+npm+webpack by esbuild (phoenixframework#4377)
|
Бу |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.