Pie attempts to install missing build tools without sudo

[hackel]

What are you trying to do?
Trying to install a package.

What platform, and PIE version are you using?
Amazon Linux 2023

🥧 PHP Installer for Extensions (PIE) 1.4.2, from The PHP Foundation
You are running PHP 8.4.10
Target PHP installation: 8.4.10 nts, on Linux/OSX/etc x86_64 (from /usr/bin/php)

Steps to reproduce the issue

1. pie install -v phpredis/phpredis

What do you expect to happen?

Checking if all build tools are installed.
The following build tools are missing: bison, re2c
The following command will be run: dnf install -y bison re2c
Would you like to install them now? Y

Packages are installed with sudo.

What is actually happening

Could not install the missing build tools. You may need to install them manually.
Symfony\Component\Process\Exception\ProcessFailedException: The command "'dnf' 'install' '-y' 'bison' 're2c'" failed
Error: This command has to be run with superuser privileges (under the root user on most systems).
 in phar:///usr/local/bin/pie/vendor/symfony/process/Process.php:271

Complete logs/output
See above.

Anything else?
After encountering the ProcessFailedException, Pie didn't stop to give me a chance to correct (or even see) the error. It continued with the build, and in this case, it happened to work just fine without those two packages. It eventually did use sudo to install the compiled extension itself.

[ralphschindler]

Ran into the related issue from the extension maintainer side. I'm the maintainer of rdkafka/rdkafka and was testing PIE installation in a minimal container. PIE blocked on missing bison and re2c even though rdkafka has no .y or .re files anywhere in its source — those tools are simply never used in the build.

The --no-build-tools-check flag works around it, but requiring those tools unconditionally seems like the wrong default. A simple scan for .re/.y files in the extracted source before adding them to the required list would make the check accurate rather than pessimistic. As @hackel notes, the build succeeds fine without them for extensions that don't use parser generators.

[asgrim]

I will remove re2c and bison from the tool checks for now 👍 doesn't make sense for most extensions, I agree